Skip to content

Commit

Permalink
minor fix in workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
quetool committed Jul 24, 2024
1 parent 614165f commit fd5d4cb
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release_dapp_android_internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ jobs:
fastlane release_firebase project_id:$PROJECT_ID app_version:$VERSION_NUMBER
# Launch locally
# act -j build --container-architecture linux/amd64 -P macos-latest-xlarge=-self-hosted --secret-file .github/workflows/.env.secret -W .github/workflows/release_dapp_android.yml
# act -j build --container-architecture linux/amd64 -P macos-latest-xlarge=-self-hosted --secret-file .github/workflows/.env.secret -W .github/workflows/release_dapp_android_internal.yml
1 change: 0 additions & 1 deletion .github/workflows/release_wallet_android_internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:

jobs:
build:
# if: github.event.pull_request.merged == true
if: (github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'develop') || github.event_name == 'workflow_dispatch'
runs-on: macos-latest-xlarge

Expand Down
7 changes: 6 additions & 1 deletion example/dapp/android/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ platform :android do
_latest_release = firebase_app_distribution_get_latest_release(
app: "#{firebase_dapp_id}",
)
_new_build_number = _latest_release[:buildVersion].to_i + 1
if _latest_release && _latest_release[:buildVersion] && !_latest_release[:buildVersion].empty?
_new_build_number = _latest_release[:buildVersion].to_i + 1
else
_new_build_number = 1
end

_app_version = "#{options[:app_version]}"
_project_id = "#{options[:project_id]}"

Expand Down
7 changes: 6 additions & 1 deletion example/dapp/ios/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,12 @@ platform :ios do
app_identifier: "#{app_identifier}",
username: options[:username],
)
new_build_number = number + 1
if number && !number.to_s.empty?
new_build_number = number.to_i + 1
else
# Handle the case where there is no previous build number
new_build_number = 1
end

increment_build_number(
build_number: new_build_number,
Expand Down
7 changes: 6 additions & 1 deletion example/wallet/android/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ platform :android do
_latest_release = firebase_app_distribution_get_latest_release(
app: "#{firebase_wallet_id}",
)
_new_build_number = _latest_release[:buildVersion].to_i + 1
if _latest_release && _latest_release[:buildVersion] && !_latest_release[:buildVersion].empty?
_new_build_number = _latest_release[:buildVersion].to_i + 1
else
_new_build_number = 1
end

_app_version = "#{options[:app_version]}"
_project_id = "#{options[:project_id]}"

Expand Down
7 changes: 6 additions & 1 deletion example/wallet/ios/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ platform :ios do
app_identifier: "#{app_identifier}",
username: options[:username],
)
new_build_number = number + 1
if number && !number.to_s.empty?
new_build_number = number.to_i + 1
else
# Handle the case where there is no previous build number
new_build_number = 1
end

increment_build_number(
build_number: new_build_number,
Expand Down

0 comments on commit fd5d4cb

Please sign in to comment.