Skip to content

Commit

Permalink
Fixed regression: nullable optionalNamespaces
Browse files Browse the repository at this point in the history
  • Loading branch information
Sterling Long committed Jul 14, 2023
1 parent 81d778a commit 510fd0d
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 25 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.14

- Fixed regression of optionalNamespaces not being nullable

## 2.0.13

- Made message in json response nullable to resolve issues with rejection messages
Expand Down
2 changes: 1 addition & 1 deletion lib/apis/sign_api/models/json_rpc_models.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class WcSessionProposeRequest with _$WcSessionProposeRequest {
const factory WcSessionProposeRequest({
required List<Relay> relays,
required Map<String, RequiredNamespace> requiredNamespaces,
required Map<String, RequiredNamespace> optionalNamespaces,
Map<String, RequiredNamespace>? optionalNamespaces,
Map<String, String>? sessionProperties,
required ConnectionMetadata proposer,
}) = _WcSessionProposeRequest;
Expand Down
32 changes: 17 additions & 15 deletions lib/apis/sign_api/models/json_rpc_models.freezed.dart
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ mixin _$WcSessionProposeRequest {
List<Relay> get relays => throw _privateConstructorUsedError;
Map<String, RequiredNamespace> get requiredNamespaces =>
throw _privateConstructorUsedError;
Map<String, RequiredNamespace> get optionalNamespaces =>
Map<String, RequiredNamespace>? get optionalNamespaces =>
throw _privateConstructorUsedError;
Map<String, String>? get sessionProperties =>
throw _privateConstructorUsedError;
Expand All @@ -351,7 +351,7 @@ abstract class $WcSessionProposeRequestCopyWith<$Res> {
$Res call(
{List<Relay> relays,
Map<String, RequiredNamespace> requiredNamespaces,
Map<String, RequiredNamespace> optionalNamespaces,
Map<String, RequiredNamespace>? optionalNamespaces,
Map<String, String>? sessionProperties,
ConnectionMetadata proposer});

Expand All @@ -374,7 +374,7 @@ class _$WcSessionProposeRequestCopyWithImpl<$Res,
$Res call({
Object? relays = null,
Object? requiredNamespaces = null,
Object? optionalNamespaces = null,
Object? optionalNamespaces = freezed,
Object? sessionProperties = freezed,
Object? proposer = null,
}) {
Expand All @@ -387,10 +387,10 @@ class _$WcSessionProposeRequestCopyWithImpl<$Res,
? _value.requiredNamespaces
: requiredNamespaces // ignore: cast_nullable_to_non_nullable
as Map<String, RequiredNamespace>,
optionalNamespaces: null == optionalNamespaces
optionalNamespaces: freezed == optionalNamespaces
? _value.optionalNamespaces
: optionalNamespaces // ignore: cast_nullable_to_non_nullable
as Map<String, RequiredNamespace>,
as Map<String, RequiredNamespace>?,
sessionProperties: freezed == sessionProperties
? _value.sessionProperties
: sessionProperties // ignore: cast_nullable_to_non_nullable
Expand Down Expand Up @@ -422,7 +422,7 @@ abstract class _$$_WcSessionProposeRequestCopyWith<$Res>
$Res call(
{List<Relay> relays,
Map<String, RequiredNamespace> requiredNamespaces,
Map<String, RequiredNamespace> optionalNamespaces,
Map<String, RequiredNamespace>? optionalNamespaces,
Map<String, String>? sessionProperties,
ConnectionMetadata proposer});

Expand All @@ -444,7 +444,7 @@ class __$$_WcSessionProposeRequestCopyWithImpl<$Res>
$Res call({
Object? relays = null,
Object? requiredNamespaces = null,
Object? optionalNamespaces = null,
Object? optionalNamespaces = freezed,
Object? sessionProperties = freezed,
Object? proposer = null,
}) {
Expand All @@ -457,10 +457,10 @@ class __$$_WcSessionProposeRequestCopyWithImpl<$Res>
? _value._requiredNamespaces
: requiredNamespaces // ignore: cast_nullable_to_non_nullable
as Map<String, RequiredNamespace>,
optionalNamespaces: null == optionalNamespaces
optionalNamespaces: freezed == optionalNamespaces
? _value._optionalNamespaces
: optionalNamespaces // ignore: cast_nullable_to_non_nullable
as Map<String, RequiredNamespace>,
as Map<String, RequiredNamespace>?,
sessionProperties: freezed == sessionProperties
? _value._sessionProperties
: sessionProperties // ignore: cast_nullable_to_non_nullable
Expand All @@ -480,7 +480,7 @@ class _$_WcSessionProposeRequest implements _WcSessionProposeRequest {
const _$_WcSessionProposeRequest(
{required final List<Relay> relays,
required final Map<String, RequiredNamespace> requiredNamespaces,
required final Map<String, RequiredNamespace> optionalNamespaces,
final Map<String, RequiredNamespace>? optionalNamespaces,
final Map<String, String>? sessionProperties,
required this.proposer})
: _relays = relays,
Expand Down Expand Up @@ -508,13 +508,15 @@ class _$_WcSessionProposeRequest implements _WcSessionProposeRequest {
return EqualUnmodifiableMapView(_requiredNamespaces);
}

final Map<String, RequiredNamespace> _optionalNamespaces;
final Map<String, RequiredNamespace>? _optionalNamespaces;
@override
Map<String, RequiredNamespace> get optionalNamespaces {
Map<String, RequiredNamespace>? get optionalNamespaces {
final value = _optionalNamespaces;
if (value == null) return null;
if (_optionalNamespaces is EqualUnmodifiableMapView)
return _optionalNamespaces;
// ignore: implicit_dynamic_type
return EqualUnmodifiableMapView(_optionalNamespaces);
return EqualUnmodifiableMapView(value);
}

final Map<String, String>? _sessionProperties;
Expand Down Expand Up @@ -582,7 +584,7 @@ abstract class _WcSessionProposeRequest implements WcSessionProposeRequest {
const factory _WcSessionProposeRequest(
{required final List<Relay> relays,
required final Map<String, RequiredNamespace> requiredNamespaces,
required final Map<String, RequiredNamespace> optionalNamespaces,
final Map<String, RequiredNamespace>? optionalNamespaces,
final Map<String, String>? sessionProperties,
required final ConnectionMetadata proposer}) = _$_WcSessionProposeRequest;

Expand All @@ -594,7 +596,7 @@ abstract class _WcSessionProposeRequest implements WcSessionProposeRequest {
@override
Map<String, RequiredNamespace> get requiredNamespaces;
@override
Map<String, RequiredNamespace> get optionalNamespaces;
Map<String, RequiredNamespace>? get optionalNamespaces;
@override
Map<String, String>? get sessionProperties;
@override
Expand Down
6 changes: 3 additions & 3 deletions lib/apis/sign_api/models/json_rpc_models.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/apis/sign_api/sign_engine.dart
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class SignEngine implements ISignEngine {
relays: request.relays,
proposer: request.proposer,
requiredNamespaces: request.requiredNamespaces,
optionalNamespaces: request.optionalNamespaces,
optionalNamespaces: request.optionalNamespaces ?? {},
sessionProperties: request.sessionProperties,
pairingTopic: pTopic,
);
Expand All @@ -176,7 +176,7 @@ class SignEngine implements ISignEngine {
selfPublicKey: publicKey,
pairingTopic: pTopic,
requiredNamespaces: request.requiredNamespaces,
optionalNamespaces: request.optionalNamespaces,
optionalNamespaces: request.optionalNamespaces ?? {},
sessionProperties: request.sessionProperties,
completer: completer,
),
Expand Down Expand Up @@ -935,7 +935,7 @@ class SignEngine implements ISignEngine {
relays: proposeRequest.relays,
proposer: proposeRequest.proposer,
requiredNamespaces: proposeRequest.requiredNamespaces,
optionalNamespaces: proposeRequest.optionalNamespaces,
optionalNamespaces: proposeRequest.optionalNamespaces ?? {},
sessionProperties: proposeRequest.sessionProperties,
pairingTopic: topic,
generatedNamespaces: namespaces,
Expand Down
2 changes: 1 addition & 1 deletion lib/apis/utils/constants.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class WalletConnectConstants {
static const SDK_VERSION = '2.0.12';
static const SDK_VERSION = '2.0.14';

static const CORE_PROTOCOL = 'wc';
static const CORE_VERSION = 2;
Expand Down
2 changes: 1 addition & 1 deletion lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: walletconnect_flutter_v2
description: WalletConnect v2 client made in dart for flutter.
version: 2.0.13
version: 2.0.14
repository: https://github.com/WalletConnect/WalletConnectFlutterV2

environment:
Expand Down

0 comments on commit 510fd0d

Please sign in to comment.