Rails 5.1 & passing tests #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zysim
reviewed
Mar 3, 2020
| @@ -11,8 +11,7 @@ | |||
| // about supported directives. | |||
| // | |||
| //= require jquery | |||
| //= require jquery.cookie | |||
| //= require js.cookie | |||
There was a problem hiding this comment.
I know this probably does not matter, but should this have changed?
There was a problem hiding this comment.
I think this is necessary with the change from the jquery-cookie-rails gem, which seemed to be incompatible with newer versions of rails, to the newer js_cookie_rails gem. But I don't have a good idea how all these bits fit together, so let me know if I'm wrong about that!
(And thanks for looking at this)
There was a problem hiding this comment.
I'll take a look at the rest of the code to the best that I can in an hour or so 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a whole lot of searching, I managed to get almost all the tests passing. Upgrading Rails was the first step, since the old version was not compatible with Ruby 2.6.
The final test ("should do race" in
score_helper_test.rbseemed to reflect an actual problem in the code. At least in 2018, we didn't use the web app for scoring, so I skipped the test rather than spending time trying to solve it.