Mailer Settings and Documentation Updates #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------ Set the ActionMailer parameters for both `production.rb` and `development.rb` to pull the email address and password from environment variables.
------ First off, server_deploy.md was separated with a comma, not a period. Secondly, I've changed the language a little in both, in hopes of streamlining what we are talking about.
|
I am really not an expert, but it looks all right to me. |
|
If you are happy with it and it blocks you from going further, I think you can merge it. |
tsaoyu
reviewed
Aug 24, 2018
| @@ -43,4 +43,12 @@ | |||
| config.action_mailer.default_url_options = { :host => "localhost:3000" } | |||
| config.action_mailer.delivery_method = :letter_opener | |||
| config.action_mailer.perform_deliveries = true | |||
| config.action_mailer.smtp_settings = { | |||
There was a problem hiding this comment.
I don't think we need this. As in @kirs 's idea, the email will be previewed in a html page.
|
|
||
| export RAILS_ENV=production | ||
| # Generate a SECRET_TOKEN; `rake secret` can generate one | ||
| export SECRET_TOKEN=<SECRET_TOKEN> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit messages should speak for themselves. Please message me if you need me to clarify anything. It's three in the morning I'm tired peace