Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more link matchers #1132

Merged
merged 9 commits into from
May 17, 2022
Merged

Conversation

kateabr
Copy link
Contributor

@kateabr kateabr commented May 12, 2022

added link matchers and icons for awa, deezer, linkcore, commons.nicovideo, recochoku and seiga.nicovideo

@ycanardeau
Copy link
Contributor

Deployed to the beta site.

@kateabr
Copy link
Contributor Author

kateabr commented May 16, 2022

Should I replace background: url('...') no-repeat left 50%; with .extLink as well?

@ycanardeau
Copy link
Contributor

Should I replace background: url('...') no-repeat left 50%; with .extLink as well?

Since removing left 50% causes an unwanted side effect, I think it's fine to leave it as is for now.

@ycanardeau ycanardeau merged commit 6f14a68 into VocaDB:main May 17, 2022
@ycanardeau
Copy link
Contributor

Thanks!

@ycanardeau
Copy link
Contributor

@kateabr Please don't forget to run the Prettier code formatter every time you save a file. I strongly recommend you set up a development environment (if you haven't done it yet) and run the npm run watch (or npm run dev) command before pushing changes to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants