Several fixes related to the entrypoint value for the macho module #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the PROCESS_MEMORY flag and the macho module, the LC_MAIN load command was badly handled, the computation of the end of a segment was invalid.
As is done for other file analysis modules, the base address of the scanned region must be added to the entrypoint when scanning with the PROCESS_MEMORY flag set.
If the unixthread command is too small, the entrypoint value is not retrieved. The function still continues executing however, and considers 0 to be the entrypoint value. This is invalid, and the entrypoint should stay undefined in those cases.
plusvic
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those fixes are mostly related to the macho module with the PROCESS_MEMORY flag, but not only:
Would be great to get those fixes in 4.4