-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record pattern matching #368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskarth
added
Type: Enhancement
New feature or request
Subsystem: Statement Structure
Anything concerning how statements are structured in a method
Priority: Medium
Medium priority
Subsystem: Parsing
Anything concerning how bytecode is parsed and read
labels
Apr 17, 2024
…es (#417) * Add support for nested record patterns * Add some comments * Add support for switches * Cleanup switch guard check and add comment
jaskarth
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: coehlrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Medium
Medium priority
Subsystem: Parsing
Anything concerning how bytecode is parsed and read
Subsystem: Statement Structure
Anything concerning how statements are structured in a method
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements record pattern matching for Vineflower. In order to implement this feature properly, I introduce a new option to switch out the try duplication strategy. Previously the decompiler would insert trampolines, but duplicating the handler is now preferred.
Currently still a WIP.