Add the option to set a persistent storage for the browser provider #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a really useful feature to have |
|
Would really be appreciated! |
|
Any updates/plans to support this? |
|
The branch is really out of date and need to be synced. If that is done, and relevant tests are added, then we can see how to prioritize it for merging. @eugenestarchenko Would you take the lead on this? |
Hamoody200
approved these changes
Aug 17, 2023
|
Is there anything new with this branch? any way to prioritize this for merge? |
|
@fernbach it cannot be merged because there is a branch conflict and missing test coverage. If both conditions are met, then we will be more than happy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using an IDP that has a browser session and providing credentials only once.
Can help #729
Example usage:
saml2aws configure --url https://account.activedirectory.windowsazure.com/applications/signin/<app_id>?tenantId=<tenantId> --persistent-data-dir ~/.persistent_data_dir -a browser --idp-provider Browser --skip-prompt