Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all session options (including region) when checking the token. #565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support all session options (including region) when checking the token. #565

wants to merge 1 commit into from

Conversation

stensonb
Copy link

This ensures token verification works in govcloud. Otherwise, when tokens are verified, the wrong region may be used.

@stensonb
Support all session options (including region) when checking the toke…
367910e 
…n. This ensures token verification works in govcloud.
@stensonb
Copy link
Author

Without this, this blocks validating tokens via Okta -> AWS STS saml workflow for govcloud accounts.

(Although, tokens generated ARE valid, they just need to point to the correct AWS_REGION to verify).

mapkon
mapkon suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@mapkon mapkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stensonb Do you still need this? If yes, can we update it from main and plan to merge it? If not, I am inclined to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapkon mapkon mapkon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stensonb @mapkon