Skip to content

Commit

Permalink
Move meta from home page to app root
Browse files Browse the repository at this point in the history
  • Loading branch information
smrtrfszm committed Jan 6, 2024
1 parent 2d945f9 commit 768bf44
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
9 changes: 8 additions & 1 deletion src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

import { ErrorBoundary, lazy, Suspense } from 'solid-js'
import 'normalize.css'
import previewImage from '~/assets/preview_image.png'
import '~/scss/global.scss'
import Layout from '~/components/Layout'
import Title from '~/components/Title'
import { RouteDefinition, Router } from '@solidjs/router'
import { MetaProvider } from '@solidjs/meta'
import { Meta, MetaProvider } from '@solidjs/meta'
import { loadHomePage } from './data/home.data'
import { loadPost } from './data/post.data'
import { loadSearchPage } from './data/search.data'
Expand Down Expand Up @@ -74,6 +75,12 @@ export default function App() {
<Suspense>
<ErrorBoundary fallback={() => null}>
<Title />
<Meta name="og:site_name" content="Verseghy Ferenc Gimnázium" />
<Meta name="og:type" content="website" />
<Meta name="og:locale" content="hu_HU" />
<Meta name="og:description" content="A szolnoki Verseghy Ferenc Gimnázium weboldala" />
<Meta name="og:image" content={previewImage} />

<Router root={Layout}>{ROUTES}</Router>
</ErrorBoundary>
</Suspense>
Expand Down
5 changes: 0 additions & 5 deletions src/pages/Home.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Component } from 'solid-js'
import Banners from '~/components/Banners'
import CardGrid from '~/components/CardGrid'
import previewImage from '~/assets/preview_image.png'
import styles from './Home.module.scss'
import { Meta } from '@solidjs/meta'
import { createAsync, RouteSectionProps } from '@solidjs/router'
Expand All @@ -12,10 +11,6 @@ const HomePage: Component<RouteSectionProps> = () => {

return (
<>
<Meta name="og:site_name" content="Verseghy Ferenc Gimnázium" />
<Meta name="og:type" content="website" />
<Meta name="og:image" content={previewImage} />
<Meta name="og:description" content="A szolnoki Verseghy Ferenc Gimnázium weboldala" />
<Meta name="twitter:card" content="summary" />

<div class={styles.container}>
Expand Down

0 comments on commit 768bf44

Please sign in to comment.