Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Split up PostsController into multiple files #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Split up PostsController into multiple files #355

wants to merge 2 commits into from

Conversation

Sasszem
Copy link
Contributor

@Sasszem Sasszem commented Jan 28, 2020

Closes #352

@Sasszem Sasszem added this to the Public Beta v1.0 milestone Jan 28, 2020
@Sasszem Sasszem requested a review from TwoDCube January 28, 2020 12:45
@Sasszem Sasszem self-assigned this Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020 •
edited
Loading

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #355   +/-   ##
=========================================
  Coverage     76.06%   76.06%           
  Complexity      126      126           
=========================================
  Files            32       32           
  Lines           305      305           
=========================================
  Hits            232      232           
  Misses           73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e285995...a0493c9. Read the comment docs.

@Sasszem
Copy link
Contributor Author

Sasszem commented Jan 28, 2020

Manual testing of the Posts API via the frontend is required due to the high number of changes!

TwoDCube
TwoDCube approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@TwoDCube TwoDCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small removal needed, other than that it LGTM

app/Http/Controllers/Posts/CountByMonth.php

namespace App\Http\Controllers\Posts;

trait CountByMonth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unused, could be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoDCube TwoDCube TwoDCube approved these changes

Assignees

@Sasszem Sasszem

Labels
Priority: Medium Type: Maintenance
Projects
None yet
Milestone
Public Beta v1.0
Development

Successfully merging this pull request may close these issues.

Break up controllers into smaller pieces
2 participants
@Sasszem @TwoDCube