Fix clippy

Verseghy · Jul 5, 2024 · e792c5c · e792c5c
1 parent bdee7a8
commit e792c5c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/cmds/src/create_iam_app.rs b/cmds/src/create_iam_app.rs
@@ -14,6 +14,6 @@ async fn main() {
 
     let (id, secret) = create_app(&database, &name).await;
 
-    println!("id: {}", id.to_string());
+    println!("id: {}", id);
     println!("secret: {}", secret);
 }
diff --git a/iam-common/src/app.rs b/iam-common/src/app.rs
@@ -48,6 +48,6 @@ where
 
     apps::Entity::insert(app).exec(db).await?;
 
-    let secret = BASE64_STANDARD_NO_PAD.encode(format!("{}:{}", id.to_string(), password));
+    let secret = BASE64_STANDARD_NO_PAD.encode(format!("{}:{}", id, password));
     Ok((id, secret))
 }
diff --git a/iam-common/src/id.rs b/iam-common/src/id.rs
@@ -1,5 +1,6 @@
 use once_cell::sync::Lazy;
 use serde::{Deserialize, Serialize};
+use std::fmt::{self, Display};
 use uuid::{
     v1::{Context, Timestamp},
     Uuid,
@@ -81,10 +82,10 @@ impl Id {
     }
 }
 
-impl ToString for Id {
-    #[inline]
-    fn to_string(&self) -> String {
-        format!(
+impl Display for Id {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(
+            f,
             "{}-{}",
             self.get_prefix(),
             self.uuid

diff --git a/iam-migration/src/m20220822_190837_remove_invite_action.rs b/iam-migration/src/m20220822_190837_remove_invite_action.rs
@@ -18,7 +18,7 @@ impl MigrationTrait for Migration {
     }
 
     async fn down(&self, _manager: &SchemaManager) -> Result<(), DbErr> {
-        todo!();
+        Ok(())
     }
 }
 

diff --git a/iam/src/main.rs b/iam/src/main.rs
@@ -6,7 +6,7 @@ fn audit_filter(metadata: &tracing::Metadata<'_>) -> bool {
     if metadata.is_event() {
         return metadata.target().starts_with("audit");
     }
-    return metadata.name().starts_with("audit");
+    metadata.name().starts_with("audit")
 }
 
 #[tokio::main]