Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ViewIcons blocking opening profile in DMs #2666

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Obsidianninja11
Copy link

The ViewIcons plugin was blocking users from opening the bigger profile by clicking the pfp in the right side panel in dms

Image of where I'm talking about

image

Before fix: Clicking on this pfp would open the pfp as an image preview
After fix: Clicking on this pfp opens the big profile view as expected

@Scyye
Copy link
Contributor

Scyye commented Jul 5, 2024

Looking at it, this doesnt seem like a fix, more of just a.. feature removal..

i'd add a setting for it, and add a predicate to those 2 patches.

@Obsidianninja11
Copy link
Author

Obsidianninja11 commented Jul 6, 2024

Looking at it, this doesnt seem like a fix, more of just a.. feature removal..

i'd add a setting for it, and add a predicate to those 2 patches.

This is a bug. It used to not block opening from the profile menu from clicking this pfp. The feature is meant to make the normally non-clickable pfps clickable to view the avatar (and also add it to the right click menu)

(also there's already 4 ways (5 if you want to scroll to the very top of the dm) to view the avatar from dms)
(and you can view the avatar from the large profile menu that opens after clicking the pfp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants