Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PatchHelper): enhance RegExp & quote syntax support #2661

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

bb010g
Copy link
Contributor

@bb010g bb010g commented Jul 3, 2024

Note

This PR is a patch stack. Do not squash these commits. This patch stack depends on:

For ease of authoring patches:

  • PatchHelper's find now canonicalizes RegExps (e.g. /\i\.foo/)
  • PatchHelper's find supports single & double quoted string syntax (while still allowing unquoted strings)
  • PatchHelper's match supports RegExp syntax
  • PatchHelper's match supports single & double quoted string syntax (while still allowing unquoted strings)
  • PatchHelper supports RegExp syntax with flags (e.g. /foo/g)
  • PatchHelper's code display shows in more situations, which helps clarify how various syntaxes are being interpreted (e.g. a find of "foo" "bar" will show as find: "\"foo\" \"bar\"", even when match is empty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant