Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditUsers #2657

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

EditUsers #2657

wants to merge 9 commits into from

Conversation

Vendicated
Copy link
Owner

@Vendicated Vendicated commented Jul 2, 2024 •
edited
Loading

Todo:

  • make nickname replacement work everywhere. need to manually patch messages & member list
  • idk if asking for image urls is a good idea. the fact that cdn links expire made this kinda painful
  • allow editing more stuff:
    • pronouns
    • avatar decoration
    • profile effects
  • add user tags (like the APP tag)

@Vendicated Vendicated changed the title sajidfjiasdjiodjioasjiod EditUsers Jul 2, 2024
@Vendicated
Copy link
Owner Author

hi! please don't open spam prs with titles like "sajidfjiasdjiodjioasjiod" or you will be blocked!!

Scyye
Scyye reviewed Jul 5, 2024
View reviewed changes
src/plugins/editUsers/modal.tsx
flagPrefer: OverrideFlags.KeepServerAvatar,
placeholder: (user: User) => user.getAvatarURL(),
},
bannerUrl: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving this here despite this being a draft;
Any chance you could include an option to use a colour picker for the banner?

kittygirlyy
kittygirlyy reviewed Jul 7, 2024
View reviewed changes
Copy link
Sponsor

@kittygirlyy kittygirlyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks >w<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittygirlyy kittygirlyy kittygirlyy left review comments

@Scyye Scyye Scyye left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vendicated @kittygirlyy @Scyye