ShowMeYourName - Fixed possible false positive bug

[Jono997]

There seems to be a bug where when a user's name has capital letters, this plugin always acts as if the username and nickname are different. This is my attempt to fix it.

[RealityWinner]

@Bloofield This broke due to your previous PR #2630

[Bloofield]

@Bloofield This broke due to your previous PR #2630

Interesting. I assumed usernames would always be lowercase which is why I didn't add the lowercase conversion for usernames

[Jono997]

So will this be merged or the other PR reverted?

[Bloofield]

@Jono997 This one should be merged. There needs to be a lowercase conversion to prevent duplicate usernames from showing up.

The thought behind the original PR was to prevent nicknames with capitalisation in them from being shown.

[hideki2k02]

Up on this. Just waiting for this to get merged so I can make a few changes too

[RealityWinner]

@Vendicated can you please merge this and fix the broken plugin since #2630 you merged the other day

[Jono997]

@Vendicated Sorry for bugging you again, but can you please take a look at this?

[Jono997]

Well, uh, that's one way to solve the problem.

[maddie480]

Uh yeah, that's just a fork I made for myself for developing a plugin 😅 And given that I rebase the branch to keep my Vencord up-to-date, I'm spamming quite a bit here, I'm going to remove the mention

(also, I didn't mean to mock anyone with that trollface message there, that's why I amended the commit 1 minute later but well, it was too late)