Tpp token support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provided a new Connector class VenafiConnection which provides a TPP connector with support for Token authentication Connection class is deprecated. Added required tests and fixes. Added log entries for easier debugging.
tr1ck3r
reviewed
Nov 11, 2020
There was a problem hiding this comment.
Looks good to me @rvelaVenafi I added a few comments that I would like you to consider.
…change will make easier to differentiate between the tpp_token and the cloud apikey variables. Fixed some typos.
…change will make easier to differentiate between the tpp_token and the cloud apikey variables. Fixed some typos.
…change will make easier to differentiate between the tpp_token and the cloud apikey variables. Fixed some typos.
…change will make easier to differentiate between the tpp_token and the cloud apikey variables. Fixed some typos.
…change will make easier to differentiate between the tpp_token and the cloud apikey variables. Fixed some typos.
tr1ck3r
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Token authentication.
Deprecated Connection class
Added VenafiConnection class with support for TPP token.
Added test suite for Token authentication
Added log entries for easier debugging.
General fixes and best practices changes.