Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken Devanagari verses #5

Closed
wants to merge 1 commit into from

Conversation

vlastavesely
Copy link

@bkis
Copy link
Member

bkis commented Sep 16, 2024

Hi Vlasta,

thanks a lot for taking the time to contribute!
The .tei files are generated from other sources curated by us. They are not meant to be edited manually, as any changes will be overwritten when the files are generated the next time. The Devanagari version used here is this one – also a file in this repository.

As this CSV contains the full content, I suspect there is an error in our transformation logic (the one generating the .tei files). Thank you for pointing this out to us! I will tag @an-fischer to raise awareness, as this is likely her move to make.

I am going to keep this PR open until we fixed the issue so you're informed whenever this happens. Again, thank you!

@bkis bkis added the bug Something isn't working label Sep 16, 2024
@an-fischer
Copy link
Collaborator

Thank you very much for pointing out this error! I identified the problem in our transformation logic, I will check whether it concerns other source data as well, and will let you know as soon as the problem is fixed.

@an-fischer
Copy link
Collaborator

Hallo Vlasta, we updated some of the data (mostly the morphological annotations) and also fixed the error in the transformation logic that made parts of Eichler's text (and also Aufrecht's by the way) disappear. So it should be fixed by now. Thanks again for pointing this out to us!

@vlastavesely
Copy link
Author

Sehr gut, thanks for fixing this.

@bkis
Copy link
Member

bkis commented Oct 17, 2024

The update of the platform will go live ASAP – I think tomorrow might be realistic. Thanks again!

@vlastavesely
Copy link
Author

Nicht zu danken. Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants