Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: common sourcemod plugin folder hierarchy #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxime1907
Copy link

No description provided.

Copy link
Owner

@Vauff Vauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the justification for this? I suppose it saves going 2 folders deeper on your server during the install process, but then does the opposite whenever navigating the project folder in a file explorer.

Also please do not remove the pre-compiled .smx, this is provided for beginner users who may not be familiar with the process for compiling plugins.

@maxime1907
Copy link
Author

maxime1907 commented Aug 23, 2022

What's the justification for this? I suppose it saves going 2 folders deeper on your server during the install process, but then does the opposite whenever navigating the project folder in a file explorer.

Also please do not remove the pre-compiled .smx, this is provided for beginner users who may not be familiar with the process for compiling plugins.

Its just that there are no general consensus regarding how independent plugins should be structured so i am trying to push that structure so that later on we can use scripts to automate the building process and if for instance we have resources that are specific for CSS, CSGO, TF2.. we also have a clean structure.

What do you think about that hierarchy (implemented here https://github.com/srcdslab/sm-plugin-zombiereloaded):

  • addons
    • metamod
    • sourcemod
      • scripting
        • include
      • gamedata
      • translations
  • cstrike
    • materials
    • models
  • csgo
    • materials
    • models

About pre-compiled .smx in git repositories, its just that it should not belong here but rather in the release part of github with proper CI/CD like any other normal github repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants