Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_p2p : make the RunProcessInThread a daemon thread so we cleanly exit on error. #339

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

TTimo
Copy link
Contributor

@TTimo TTimo commented Sep 29, 2024

If the script calls sys.exit(1) on error, it would get stuck because the threads are not marked daemon and keep running (the trivial_signaling_server process).

@zpostfacto zpostfacto merged commit 538ae81 into ValveSoftware:master Sep 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants