Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a boolean setting to show the 'arrange' button in the UI. #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fire
Copy link

@fire fire commented Jun 30, 2024

I am trying to restore auto-arrange. Do you remember why it was removed?

Recording.2024-06-29.210043.mp4

I noticed that auto-arrange undo and redo is bugged - Will fill a bug report.

Also frames are not interacting.

I might be able to get these changed patched upstream.

@fire
Copy link
Author

fire commented Jun 30, 2024

I propose that this is kept in the settings menu off by default so I can debug it.

@Naros
Copy link
Member

Naros commented Jun 30, 2024

Hi @fire, thanks for the contribution.

If I recall, there was an issue with auto-arrange where it places the nodes in really obscure ways stacked in really tall vertical way rather than horizontal like you would normally expect, so we disabled it. I certainly don't mind using a toggle for this.

As for the comment nodes, those aren't GraphFrame types. The GraphFrame class wasn't added to Godot 4.2, so we had to roll our own implementation based on GraphNode. Unfortunately GraphEdit isn't designed well for extended implementations to really override a lot of the behavior.

There is a GH issue to port comments to GraphFrame for Orchestrator 2.1, but this won't be possible for 2.0 since that must remain based on Godot 4.2 -- unless upstream backports GraphFrame to 4.2 ofc.

@Naros
Copy link
Member

Naros commented Jun 30, 2024

Here's a great example, this is the event graph for camera.torch:

image

Now, when using the auto-arrange feature:

image

I haven't looked at the logic in GraphEdit in the upstream, but that really doesn't make it look any better IMO.

I did see this in the upstream godotengine/godot#87492, and I wanted to port this to C++ and see how it would work on our event graphs, it's on my todo list to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants