ci: use jq for JSON parsing, avoid cut for querying version from tag #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibaud CANALE <[email protected]>
|
Oh, I see now the purpose of this PR... I didn't see the failures. |
|
@thican Thx |
|
Thanks you, @daiyam, and also all contributors for all this years on this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on recent job failure, I think this should be more reliable; it is not good practice to use text parsing tools (grep, sed, and more) for JSON parsing.
Based on other scripts,
jqis already used elsewhere so let’s use it there too.Also use variables TAG and VERSION for readability.