refactor: generalized RPM install instructions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalized distro names, list them once at the beginning (Fedora and Enterprise Linux have too many derivatives) Also documented the install on Fedora Atomic Desktops etc.
daiyam
requested changes
Dec 27, 2024
There was a problem hiding this comment.
@boredsquirrel Thanks for the PR. I've added some comments.
| @@ -142,17 +142,27 @@ sudo apt update && sudo apt install codium | |||
| --- | |||
|
|
|||
| <a tabindex="-1" aria-hidden="true" id="rpm" href="#rpm"></a> | |||
| ### Install on Fedora / RHEL / CentOS / RockyLinux / OpenSUSE (rpm package): | |||
| ### Install on Fedora / Enterprise Linux / OpenSUSE (rpm package): | |||
There was a problem hiding this comment.
Remove the list and keep it simple as ### Install on Fedora / RHEL / RockyLinux / OpenSUSE (rpm package):
|
|
||
| Add the GPG key of the repository: | ||
|
|
||
| ```bash | ||
| sudo rpmkeys --import https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/-/raw/master/pub.gpg | ||
| curl -O https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/-/raw/master/pub.gpg | ||
| sudo install -o 0 -g 0 -m644 pub.gpg /etc/pki/rpm-gpg/vscodium.gpg |
There was a problem hiding this comment.
Ahat's the benefit compared to rpmkeys --import?
| ``` | ||
|
|
||
| Add the repository: | ||
|
|
||
| - **Fedora/RHEL/CentOS/Rocky Linux**: | ||
| - **Fedora / Enterprise Linux etc.**: |
| @@ -166,10 +176,14 @@ Add the repository: | |||
| Install the software: | |||
| (if you want vscodium-insiders, then replace `codium` by `codium-insiders`) | |||
|
|
|||
| - **Fedora/RHEL/CentOS/Rocky Linux**: | |||
| - **Fedora/Enterprise Linux etc.**: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generalized distro names, list them once at the beginning (Fedora and Enterprise Linux have too many derivatives)
Also documented the install on Fedora Atomic Desktops etc.