-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement next/last argument text-objects from targets.vim #8153
base: master
Are you sure you want to change the base?
Conversation
ff25852
to
c8214e4
Compare
603d17a
to
1afc7b3
Compare
I think it's ready for review and trying out. However, some tests unrelated to this implementation seem to fail. 22 tests will fail (on master it's 16), I tested some of them by hand and they seemed to be okay 🤨 |
Thanks for the PR! I'm already waiting for it to get merged! |
Just made a quick test and it will indeed jump to If you need the argument text object to work with brackets only, you can try modifying |
Okay. |
Maybe we can get a toggle switch on this. If checked then make it work with brackets only 🤔 |
Logger API changed; should just be |
Got it —— I'm currently busy with academic stuff, would come back later to address the issue and maybe revamp the ineffective algorithm. By the way, I wonder what's your opinion towards this? Should we implement the exact behavior of the original plugin, or upgrade it to recognize the brackets it's currently in?
|
Don't have a strong opinion. Being consistent with original plugin is generally better, but I'll leave it up to you |
What this PR does / why we need it:
Implements next/last argument text-objects from
targets.vim
.Use
<operator><i/a>na/la
anywhere to access the next/last argument. It will look for the next/last one in the buffer if there are no arguments under the cursor.Which issue(s) this PR fixes
Contributes to #601
Special notes for your reviewer: