Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] ✨ Log extra JWT claims in AuditTrail #189

Draft
wants to merge 1 commit into
base: stable/1.1.x
Choose a base branch
from

Conversation

stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented Jan 11, 2022

issue: open-zaak/open-zaak#1088

New JWT claims:

  • roles
  • department
  • company
  • kvk

TODO:

  • base stable/1.1.x off of stable/1.0.x and merge to that?

@stevenbal stevenbal marked this pull request as draft January 11, 2022 15:49
@codecov-commenter
Copy link

Codecov Report

Merging #189 (7f793dd) into stable/1.0.x (71ffd44) will increase coverage by 0.09%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           stable/1.0.x     #189      +/-   ##
================================================
+ Coverage         41.94%   42.03%   +0.09%     
================================================
  Files                79       79              
  Lines              3350     3359       +9     
  Branches            613      613              
================================================
+ Hits               1405     1412       +7     
- Misses             1886     1888       +2     
  Partials             59       59              
Impacted Files Coverage Δ
vng_api_common/audittrails/viewsets.py 0.00% <0.00%> (ø)
vng_api_common/audittrails/models.py 100.00% <100.00%> (ø)
vng_api_common/fields.py 42.85% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ffd44...7f793dd. Read the comment docs.

@stevenbal stevenbal changed the base branch from stable/1.0.x to stable/1.1.x January 17, 2022 09:03
issue: open-zaak/open-zaak#1088

New JWT claims:
- roles
- department
- company
- kvk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants