C37.118 synchrophasor protocol node #652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stv0g
requested changes
Jul 30, 2024
include/villas/nodes/c37_118.hpp
Outdated
| * @author Philipp Jungkamp <[email protected]> | ||
| * @copyright 2014-2022, Institute for Automation of Complex Power Systems, EONERC | ||
| * @license Apache 2.0 | ||
| *********************************************************************************/ |
There was a problem hiding this comment.
Please check the new file headers. I think still style is not up-to-date anymore.
include/villas/nodes/c37_118.hpp
Outdated
| int stop() override; | ||
| }; | ||
|
|
||
| } /* namespace c37_118 */ |
There was a problem hiding this comment.
I think we now use C++ style comments.
Suggested change
| } /* namespace c37_118 */ | |
| } // namespace c37_118 |
| @@ -0,0 +1,180 @@ | |||
| /** | |||
There was a problem hiding this comment.
File header style (as above)
| Status status(Result); | ||
| bool is_ok(Result); | ||
|
|
||
| // context used to assemble and disassemble data frames with the information contained in config structs |
There was a problem hiding this comment.
Please make comments a sentence: start with capital letter and end with period.
Suggested change
| // context used to assemble and disassemble data frames with the information contained in config structs | |
| // Context used to assemble and disassemble data frames with the information contained in config structs. |
| size_t pmu_index; | ||
| }; | ||
|
|
||
| // placeholder type allowing deferred assignment to a field during serialization |
| @@ -0,0 +1,145 @@ | |||
| #include <array> | |||
|
|
||
| uint16_t calculate_crc(unsigned char *frame, uint16_t size); | ||
|
|
||
| } /* namespace parser */ |
| namespace c37_118 { | ||
| namespace types { | ||
|
|
||
| // cartesian phasor representation |
| Format imaginary; | ||
| }; | ||
|
|
||
| // polar phasor representation |
| }; | ||
|
|
||
| template <typename Format> | ||
| struct Polar<Format, false> |
There was a problem hiding this comment.
I think this code isnt clang-format'ed yet..
|
Hey @PJungkamp, I am wondering: are you still actively working on this? I did some initial review. But it really appears to be still in a draft state.. In order to merge it we are still missing:
(I will add those point to the PR description as well) |
PJungkamp
force-pushed
the
node-c37.118
branch
from
4ae7a31
to
27141a1
Compare
PJungkamp
force-pushed
the
node-c37.118
branch
2 times, most recently
from
041b761
to
424d974
Compare
This includes a simple self-contained parser for IEEE Std C37.118.2 and a corresponding unit test. The C37.118 node type is a dead stub. Signed-off-by: Philipp Jungkamp <[email protected]>
PJungkamp
force-pushed
the
node-c37.118
branch
from
424d974
to
75b2444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #254
ToDo