bugfix: prevent unintended shared metadata updates in function assign_and_map_hash_ids
#3385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
short description
This short PR addresses a bug in the
assign_and_map_hash_ids
function where multipleElement
instances could share the sameElementMetadata
instance.This could inadvertently introduce unintended side effects when updating the
parent_id
.original behavior
Here it will raise the
KeyError
since the underlying metadata object could have been updated earlier pointed by the other element associated with the same metadata object.