Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: The <div> text element with one <br> will not be regarded as a text element by _is_text_tag #3209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

heya5
Copy link

@heya5 heya5 commented Jun 14, 2024

The below element will not be regarded as a text element by _is_text_tag:

<div>AI solutions <br> which suit you</div>

So we should ignore <br> tag when consider the point:

    # NOTE(robinson) - This indicates that a div tag has no children. If that's the
    # case and the tag has text, its potential a text tag

@heya5 heya5 changed the title fix missing <div> text element with one <br> FIX: The <div> text element with one <br> will not be regarded as a text element by _is_text_tag Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant