Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bug fix for table metric #3025

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add bug fix for table metric #3025

wants to merge 2 commits into from

Conversation

tbs17
Copy link
Contributor

@tbs17 tbs17 commented May 15, 2024

add matching idx logic fix in table_assignment.py

@tbs17
Copy link
Contributor Author

tbs17 commented May 23, 2024

merge request as test passed

@tbs17
Copy link
Contributor Author

tbs17 commented May 23, 2024

Summary
This fix is to apply on the table structure metric calculation
Additional Context:
This PR was originally created as testing Draft PR. Now it passes testing and we would like to change the draft to real PR and merged to the main branch.

Originally, the Draft PR didn't contain the latest change on the main because it was created from core-product route. Now it got updated with the latest change on main by 20240523.

@tbs17 tbs17 marked this pull request as ready for review May 23, 2024 17:16
github-merge-queue bot pushed a commit that referenced this pull request Jun 10, 2024
**Summary**
This fix is to provide better logic oon matched_idx of calculating table
structure metric to provide more accurate calculation on the acc
**Additional Context**

- this fix has passed CI run in Draft PR #3025 initially
- therefore, this time we would like to merge into main branch
- this commit has merged the latest change from main after the Draft PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant