Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated set payload, zero ftsensor and set tool voltage to use the ur… #567

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Updated set payload, zero ftsensor and set tool voltage to use the ur… #567

merged 3 commits into from
Nov 30, 2022

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Aug 16, 2022

…driver

This makes it possible to call the commands when the robot is in local control if the external control script is running on the robot.

This is a solution to #562.

This PR requires the changes from this PR in the client library

@fmauch fmauch added the waiting_for_sync Waiting for a sync of upstream packages label Oct 10, 2022
fmauch
fmauch approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it seems to work nicely. Waiting for melodic and noetic sync before merging.

@fmauch fmauch closed this Oct 14, 2022
@fmauch fmauch reopened this Oct 14, 2022
@miguelprada miguelprada mentioned this pull request Oct 18, 2022
Closed
@gavanderhoorn gavanderhoorn mentioned this pull request Oct 18, 2022
Closed
fmauch
fmauch requested changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as done in #582 we should add it to the ROS_INTERFACE,md documentation.

ur_robot_driver/launch/ur_common.launch Outdated Show resolved Hide resolved
@fmauch fmauch linked an issue Oct 18, 2022 that may be closed by this pull request
Multi robot control broken, Failed to bind socket for port 50004 to address #581
Closed
urmahp and others added 2 commits October 18, 2022 19:52
@urmahp @fmauch
Updated set payload, zero ftsensor and set tool voltage to use the ur…
12f6baf 
…driver

This makes it possible to call the commands when the robot is in local control if the external control script is running on the robot.
@miguelprada @fmauch
Update ROS interface docs
550c200
@fmauch
Copy link
Collaborator

fmauch commented Oct 18, 2022

I've cherry picked the docs update from #582, thanks @miguelprada

fmauch
fmauch approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the recent changes we would be back to waiting for the sync again.

This was referenced Nov 28, 2022
Merged
Merged
@fmauch fmauch merged commit c106244 into UniversalRobots:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
waiting_for_sync Waiting for a sync of upstream packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi robot control broken, Failed to bind socket for port 50004 to address
3 participants
@urmahp @fmauch @miguelprada