Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joint_trajectory_controller execution - set stopped_velocity_tolerance to zero #37

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

livanov93
Copy link
Contributor

@livanov93 livanov93 commented Feb 7, 2021

@MGBla Addresses #36

@livanov93 livanov93 self-assigned this Feb 8, 2021
@livanov93 livanov93 requested a review from MGBla February 8, 2021 21:53
@MGBla
Copy link
Contributor

MGBla commented Feb 9, 2021

It seems like the parameters are not added to the parameter service. There are only the following parameters:

/ur_joint_trajectory_controller:
  action_monitor_rate
  allow_partial_joints_goal
  constraints.goal_time
  constraints.stopped_velocity_tolerance
  joints
  state_publish_rate
  use_sim_time

As stated in #36 the root of the error was the stopped_velocity_tolerance.
But on a general note, I really don't think we should specify the tolerances in this yaml file. Since the JointTrajector msg specifies all the tolerance in its definition I think we would circumvent the intended mechanics here.

@livanov93 livanov93 changed the title Fix joint_trajectory_controller execution - add goal and state tolerances per joint Fix joint_trajectory_controller execution - set stopped_velocity_tolerance to zero Feb 11, 2021
@livanov93 livanov93 merged commit 5ecb4be into develop Feb 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the livanov/detail_jtc_params branch February 13, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants