Modifiy parameter declaration - approach equalization with ros-controls dependencies #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
========================================
+ Coverage 3.53% 3.59% +0.05%
========================================
Files 13 13
Lines 962 947 -15
Branches 152 152
========================================
Hits 34 34
+ Misses 858 843 -15
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
destogl
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Small comment, otherwise good. the same changes as in ros-controls/ros2_controllers#224
Co-authored-by: Denis Štogl <[email protected]>
destogl
added a commit
that referenced
this pull request
Sep 2, 2021
…ls dependencies (#152) * Adapt parameter declaration. * Move declaration to templated version. * Remove unnecessary node declaration. Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: Denis Štogl <[email protected]>
destogl
added a commit
that referenced
this pull request
Sep 8, 2021
…ls dependencies (#152) * Adapt parameter declaration. * Move declaration to templated version. * Remove unnecessary node declaration. Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: Denis Štogl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR info:
ur_controllerspackage which components inherit fromControllerInterface