Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pose_broadcaster to publish the TCP pose #1108

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Sep 19, 2024

This uses the PoseBroadcaster currently written by @RobertWilbrandt. As he wants to contribute that to ros2_controllers, this will stay in a draft state until it is merged upstream.

Comment on lines +8 to +9
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git
version: pose_broadcaster
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git
version: pose_broadcaster
url: https://github.com/UniversalRobots/Universal_Robots_ROS2_Description.git
version: rolling

Comment on lines +20 to +21
url: https://github.com/RobertWilbrandt/ros2_controllers
version: pose_broadcaster
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://github.com/RobertWilbrandt/ros2_controllers
version: pose_broadcaster
url: https://github.com/ros-controls/ros2_controllers
version: master

Comment on lines +8 to +9
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git
version: pose_broadcaster
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git
version: pose_broadcaster
url: https://github.com/UniversalRobots/Universal_Robots_ROS2_Description.git
version: rolling

Comment on lines +20 to +21
url: https://github.com/RobertWilbrandt/ros2_controllers
version: pose_broadcaster
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://github.com/RobertWilbrandt/ros2_controllers
version: pose_broadcaster
url: https://github.com/ros-controls/ros2_controllers
version: master

@gavanderhoorn
Copy link
Contributor

High-level question: would it perhaps be better to have the hardware interface offer a quaternion instead of an Euler angle triplet?

That would seem cleaner to me, in the sense of it being more of an N-to-1 mathematical abstraction.

While they aren't necessarily very human friendly, quaternions have definite benefits mathematically, and making it the responsibility of the hardware interface/driver to convert whatever internal orientation representation it uses to this 'intermediary representation' would seem to make sense.

@fmauch
Copy link
Collaborator Author

fmauch commented Sep 26, 2024

High-level question: would it perhaps be better to have the hardware interface offer a quaternion instead of an Euler angle triplet?

That would seem cleaner to me, in the sense of it being more of an N-to-1 mathematical abstraction.

While they aren't necessarily very human friendly, quaternions have definite benefits mathematically, and making it the responsibility of the hardware interface/driver to convert whatever internal orientation representation it uses to this 'intermediary representation' would seem to make sense.

I was discussing that with @RobertWilbrandt, as well and I would agree. But I think that's a question to discuss once the PR on ros2_controllers is there.

@gavanderhoorn
Copy link
Contributor

Oh, just noticed #856 actually does it that way.

@RobertWilbrandt
Copy link
Collaborator

I don't have any strong opinions on this - Going through REP 103 i went through the options and preferred RPY because the values cannot represent any invalid state (while i would expect that a quaternion should be normalized). From an application point of view i agree, so i changed the representation in pose_broadcaster now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants