-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pose_broadcaster to publish the TCP pose #1108
base: main
Are you sure you want to change the base?
Conversation
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git | ||
version: pose_broadcaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git | |
version: pose_broadcaster | |
url: https://github.com/UniversalRobots/Universal_Robots_ROS2_Description.git | |
version: rolling |
url: https://github.com/RobertWilbrandt/ros2_controllers | ||
version: pose_broadcaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://github.com/RobertWilbrandt/ros2_controllers | |
version: pose_broadcaster | |
url: https://github.com/ros-controls/ros2_controllers | |
version: master |
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git | ||
version: pose_broadcaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://github.com/fmauch/Universal_Robots_ROS2_Description.git | |
version: pose_broadcaster | |
url: https://github.com/UniversalRobots/Universal_Robots_ROS2_Description.git | |
version: rolling |
url: https://github.com/RobertWilbrandt/ros2_controllers | ||
version: pose_broadcaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://github.com/RobertWilbrandt/ros2_controllers | |
version: pose_broadcaster | |
url: https://github.com/ros-controls/ros2_controllers | |
version: master |
High-level question: would it perhaps be better to have the hardware interface offer a quaternion instead of an Euler angle triplet? That would seem cleaner to me, in the sense of it being more of an While they aren't necessarily very human friendly, quaternions have definite benefits mathematically, and making it the responsibility of the hardware interface/driver to convert whatever internal orientation representation it uses to this 'intermediary representation' would seem to make sense. |
I was discussing that with @RobertWilbrandt, as well and I would agree. But I think that's a question to discuss once the PR on ros2_controllers is there. |
Oh, just noticed #856 actually does it that way. |
I don't have any strong opinions on this - Going through REP 103 i went through the options and preferred RPY because the values cannot represent any invalid state (while i would expect that a quaternion should be normalized). From an application point of view i agree, so i changed the representation in pose_broadcaster now. |
This uses the PoseBroadcaster currently written by @RobertWilbrandt. As he wants to contribute that to ros2_controllers, this will stay in a draft state until it is merged upstream.