Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for forward_velocity_controller test (backport #1076) #1091

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 4, 2024

This PR aims to fix the test for the forward_velocity_controller: basically the related config file was missing the publish_topic parameter. Now when the controller is active, the velocity goals are correctly sent by launching test_forward_velocity_controller.launch.py.


This is an automatic backport of pull request #1076 done by Mergify.

* Update config with correct parameters and names

* Changed name for better description of the file

(cherry picked from commit b422d49)

# Conflicts:
#	ur_robot_driver/launch/test_forward_velocity_controller.launch.py
Copy link
Author

mergify bot commented Sep 4, 2024

Cherry-pick of b422d49 has failed:

On branch mergify/bp/humble/pr-1076
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b422d49.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ur_robot_driver/config/test_velocity_goal_publishers_config.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ur_robot_driver/launch/test_forward_velocity_controller.launch.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added conflicts humble Relevant for humble and higher ROS versions labels Sep 4, 2024
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems as if for humble this change is not necessary. The test works without this modification.

@fmauch fmauch closed this Sep 4, 2024
@fmauch fmauch deleted the mergify/bp/humble/pr-1076 branch September 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts humble Relevant for humble and higher ROS versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants