Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dash-separated user warning #146

Open
wants to merge 1 commit into
base: dev-ros2
Choose a base branch
from

Conversation

JToolGD
Copy link

@JToolGD JToolGD commented May 6, 2022

Proposed change(s)

When building the code I got the following warnings:

UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead

UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead

Types of change(s)

  • Bug fix

Testing and Verification

I did as the user warning said and simply replaced the dash with an underscore.

Test Configuration:

  • Unity machine OS + version: [Ubuntu 20.04]
  • ROS machine OS + version: [Ubuntu 20.04, ROS2 Foxy]

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@unity-cla-assistant
Copy link

unity-cla-assistant commented May 6, 2022

CLA assistant check
All committers have signed the CLA.

@kimushun1101 kimushun1101 mentioned this pull request May 11, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants