Shader Graph CPU performance improvements #7655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some simple performance improvements. Would be good to take these into new commits as well and could be backported Since nothing changed for the end user I did not make changelog edits. Is that necessary? Improved CPU performance with: - Use native cound and lenth instead of LINQ - Simplify string comparison - Simplify LINQ statements - Use Addrange instead of Add in loops - Merge .position and .rotation into .SetPositionAndRotation - Re order vector calculation - Merge if-else return into return
smitdylan2001
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple performance improvements. Would be good to take these into new commits as well and could be backported Since nothing changed for the end user I did not make changelog edits. Is that necessary?
Improved CPU performance with:
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Improve CPU performance with minor fixes
Testing status
Describe what manual/automated tests were performed for this PR
No major changes made to code
Comments to reviewers
Notes for the reviewers you have assigned.
Do I need to add changelog changes?
Can this be backported?