BUG: Fix decompressing all zlib data for NIDS #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was only expanding the buffer by 10000 bytes as it read through. This resulted in blowing the array bounds when the last, noncompressed chunk of data was larger than this. This was easily broken by products with a single compressed chunk, followed by all uncompressed data. A representative data file and smoke test is included.
lesserwhirls
approved these changes
Nov 11, 2024
|
FYI, this particular compression should only impact NIDS/Level 3, there should be no impact on the Level 2 decompression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Code was only expanding the buffer by 10000 bytes as it read through. This resulted in blowing the array bounds when the last, noncompressed chunk of data was larger than this. This was easily broken by products with a single compressed chunk, followed by all uncompressed data. A representative data file and smoke test is included.
This was actually triggered by a failure to build Siphon docs trying to access this data over CDMRemote.
PR Checklist
until ready for review