Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr unit tests and minor cleanups #1352

Merged
merged 10 commits into from
Jun 3, 2024

Conversation

tdrwenski
Copy link
Contributor

Description of Changes

  • Add unit tests for ZArray class
  • Fix test in TestZarrIosp that was unzipping a non-zarr file and not cleaning it up after tests. This is fixed by first copying the zip file to a temporary folder before using it in the tests.
  • A few minor cleanups such as: remove unused imports, remove commented out code, remove unneeded null check

@tdrwenski tdrwenski marked this pull request as ready for review June 3, 2024 16:59
@haileyajohnson haileyajohnson merged commit b5ef7fa into Unidata:maint-5.x Jun 3, 2024
10 checks passed
@tdrwenski tdrwenski deleted the add-zarr-tests branch June 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants