Fix projection units #1233
Merged
Fix projection units #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Geostationary classes
…e as a class member
… handled elsewhere
|
Jenkins tests passing: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/25/ |
haileyajohnson
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Some NCSS requests are failing for satellite data (geostationary projection) when the x/y axes have units micro radians. This PR fixes this by moving the unit handling out of the projection class, into the
HorizCoordSysclass that is used by coverages. This PR contains:HorizCoordSysusing theSimpleUnitsto work for more than just km/m, given that a projection specifies its default unit.Geostationaryrelated to unit handling.GeostationaryandLambertConformalclasses.