Add SPC hatch effect for PlotGeometry #2086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hatching effect to mimic hatching used for SPC probabilistic severe weather outlooks. Testing and an example were also added. Closes Unidata#2063
Eliminate geopandas import issues by just creating a shapely.Polygon
dopplershift
reviewed
Sep 8, 2021
| @@ -498,6 +500,23 @@ def lookup_map_feature(feature_name): | |||
| return feat.with_scale(scaler) | |||
|
|
|||
|
|
|||
| @exporter.export | |||
| class SPCHatch(matplotlib.hatch.Shapes): | |||
There was a problem hiding this comment.
Can we wait on the custom hatch? Matplotlib has deprecated passing in hatch values it doesn't understand in 3.4, with plans to remove it in 3.6. Thus using this would result in an error trying to use this when matplotlib 3.6 comes out. matplotlib/matplotlib#20690 is discussing having a proper API for adding custom hatches, so it would be good for you to weigh in there (maybe with the example of what yours looks like). You could also push that forward with a draft API if you're feeling particularly driven. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hatching effect to mimic hatching used for SPC probabilistic severe weather outlooks. Testing and an example were also added.
Matplotlib complains about the fact this is a custom hatch that uses a custom string to invoke its use. It will have to be dealt with somehow as that will eventually cause and error in future versions of matplotlib.