Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: margin issue on privacy page and social icon hover #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Koushik1311
Copy link

Related Issue

  • Information about the related issue

Closes: #509

Describe the changes you've made

I have changed the tailwind classes.
Before PrivacyPolicy page only had a vertical margin auto
Now for mobile devices, it has a vertical margin of 1.25rem or 20px, and for others auto

GitHub social icon hover color change.

Type of change

What sort of change have you made:
I have changed and updated the tailwind class for article tag
Before: mx-auto
After: mx-5 sm:mx-auto

GitHub Social Icon:
Before: hover:text-gray-200
After: hover:text-blue-400

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

I have run the code on my local machine

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
image image
Original Updated
image image

Code of Conduct

@vercel
Copy link

vercel bot commented Oct 23, 2023

@Koushik1311 is attempting to deploy a commit to the Vibey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you, @Koushik1311, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mobile view Particulars
1 participant