Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2 1.7.1 update #22

Merged
merged 237 commits into from
Sep 27, 2023
Merged

libgit2 1.7.1 update #22

merged 237 commits into from
Sep 27, 2023

Conversation

andrei-balint
Copy link

No description provided.

ethomson and others added 30 commits February 15, 2019 09:21
"Insure" relates to having insurance. "ensure" means "to make sure of"
"One-thousand" shouldn't be hyphenated. It should only be hyphenated in the case of a compound modifier on the word "thousand" as in "forty-five thousand".
Fix typos in 'Optimizing unit testing'
 Housekeeping and cleanup updates
…ad packed native libraries.

LibGit2Sharp includes a number of native libraries that are built on different OSes.
These native libraries have a dependency on OpenSSL and the system c-library.

On x64, in case the Linux flavor is not known, a fallback is performed to the 'linux-x64' native library.
This library is built with a dependency on OpenSSL 1.0.
OpenSSL 1.0 is deprecated by OpenSSL 1.1, so on more recent version of Linux, the 'linux-x64' library fails to load.

On arm64, native libraries are currently included for debian.* (OpenSSL 1.1) and ubuntu.18.04 (OpenSSL 1.0).
Loading on other distros will fail.

In both cases LibGit2Sharp is probably including a library that works, but the default resolution logic
is not able to find it.

By using the 'NativeLibrary' class (.NET Core 3.0) we can extend the resolution logic, and try to load
the other native libraries that are packed with LibGit2Sharp.
Linux: support broader range of distros/architectures by trying to load packed native libraries.
Implement value adding by exposing the underlying `set_multivar`,
which supports only string values in the underlying libgit2, so no
other typed overloads are provided at this point.

The counterpart for deleting keys exposes the underlying `delete_multivar`.
No regex-based overload is exposed for consistency with the existing `Set<T>`
overloads which don't expose it either.

Also exposed the boolean return value from the `Unset` calls which
is already present in the Proxy API.

Fixes libgit2#1719.

Fix
This should fix travis failures in CI
Add support for adding and clearing multi-valued configuration
URLs without a path are perfectly valid; the path is implicitly `/`.
libgit2 was incorrectly rejecting these paths, and LibGit2Sharp was
incorrectly testing this bad behavior.  Remove this test now that
libgit2 has fixed this issue.
bording and others added 28 commits April 7, 2023 17:30
Update LibGit2Sharp.NativeBinaries to 2.0.319
Update RemoteRedirectMode to match git_remote_redirect_t
Switch to MinVer for versioning
Update LibGit2Sharp.NativeBinaries to 2.0.320
@andrei-balint andrei-balint self-assigned this Sep 27, 2023
@andrei-balint andrei-balint merged commit d418a0e into develop Sep 27, 2023
1 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.