Merge pull request #14 from UdashFramework/detach-fix

Detach selector parameter is optional
UdashFramework · May 9, 2018 · 651ae29 · 651ae29
2 parents c6bf2d0 + dc19bf5
commit 651ae29
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -17,7 +17,7 @@ before_script:
   - wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
   - sudo dpkg -i google-chrome*.deb
   # Install Selenium chromedriver
-  - wget http://chromedriver.storage.googleapis.com/2.25/chromedriver_linux64.zip
+  - wget http://chromedriver.storage.googleapis.com/2.38/chromedriver_linux64.zip
   - unzip chromedriver_linux64.zip -d selenium-bin
   - export PATH=$PWD/selenium-bin:$PATH
 

diff --git a/src/main/scala/io/udash/wrappers/jquery/JQuery.scala b/src/main/scala/io/udash/wrappers/jquery/JQuery.scala
@@ -140,7 +140,7 @@ trait JQuery extends js.Object {
 
   /** Remove the set of matched elements from the DOM. <br/>
     * See: <a href="http://api.jquery.com/detach/">jQuery Docs</a> */
-  def detach(selector: Selector): JQuery = js.native
+  def detach(selector: Selector = js.native): JQuery = js.native
 
   /** Remove all child nodes of the set of matched elements from the DOM. <br/>
     * See: <a href="http://api.jquery.com/empty/">jQuery Docs</a> */