Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for WeChat invites #2043

Closed
wants to merge 6 commits into from
Closed

UI for WeChat invites #2043

wants to merge 6 commits into from

Conversation

lucyhe
Copy link
Contributor

@lucyhe lucyhe commented Nov 11, 2015

Tested manually & ran grunt test

This requires freedomjs/freedom-social-wechat#11 to be checked in and published
Combined with the freedom pull request, fixes: #1573 and #1977

image

image

image

image

Review on Reviewable

@@ -114,7 +139,7 @@
</div>
</div>

<div>
<div hidden?='{{ selectedNetworkName != "Cloud"}}'>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div was visible in the invite screen for all social networks

@lucyhe
Copy link
Contributor Author

lucyhe commented Nov 12, 2015

Ready for review!

@lucyhe lucyhe assigned lucyhe and dborkan and unassigned lucyhe Nov 16, 2015
@trevj
Copy link
Contributor

trevj commented Feb 2, 2016

Hello!

I'm hoping to make master the default branch later this week, replacing dev. To help with that, I'll try to close all outstanding pull requests on dev, including this one. I don't need to delete this branch or anything else destructive, so please re-open this pull request once master has become the default branch.

Thanks!

@trevj
Copy link
Contributor

trevj commented Feb 4, 2016

Please re-open, on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants