Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

ran log and tested #5

Merged
merged 3 commits into from
Dec 30, 2022
Merged

ran log and tested #5

merged 3 commits into from
Dec 30, 2022

Conversation

msleckman
Copy link
Collaborator

@msleckman msleckman commented Dec 22, 2022

This PR updates the template to just have log/XX.csv targets. Resolves #3

With this change, data is pushed to the Science Base item using just this target. The function uses sb_replace_files_log(). This is an enhanced version of it's predecessor function - sb_replace_files() - but handled log/*.csv targets more easily.

Normally, with this standardization change the upload step automatically uses an 'internal task table' approach, such that data files aren't replaced every time a metadata typo is fixed for ex. The result of the Sciencebase push step is a file with timestamps for when each file got pushed that can be checked into GitHub. Having the file with timestamps in GitHub clearly shows when updates are made and will render nicely without having to build the object target locally.

Follow-up item:

@msleckman msleckman requested a review from amsnyder December 22, 2022 22:34
Copy link
Collaborator

@amsnyder amsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just skimmed the changes and they look good. Didn't test them out, but I think you did, so I think we can merge this in!

@msleckman
Copy link
Collaborator Author

added files in in_data in commit 75af63e

@msleckman msleckman merged commit 5637827 into main Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update log targets
2 participants