This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the template to just have
log/XX.csv
targets. Resolves #3With this change, data is pushed to the Science Base item using just this target. The function uses
sb_replace_files_log()
. This is an enhanced version of it's predecessor function -sb_replace_files()
- but handled log/*.csv targets more easily.Normally, with this standardization change the upload step automatically uses an 'internal task table' approach, such that data files aren't replaced every time a metadata typo is fixed for ex. The result of the Sciencebase push step is a file with timestamps for when each file got pushed that can be checked into GitHub. Having the file with timestamps in GitHub clearly shows when updates are made and will render nicely without having to build the object target locally.
Follow-up item:
sb_replace_files_log()
or fixesb_replace_files()
. Seems like some users needed tosb_replace_files_log()
version, but others had no issues. For example, in this recently published dr repo,sb_replace_files()
was used on a log target without issues. To investigate in issue Investigate diff betweensb_replace_files()
andsb_replace_files_log()
#6