Time zone capitilization #164
Conversation
| @@ -53,15 +53,21 @@ class TestModelFrameworkMST(SMRFTestCase): | |||
| """ | |||
| Test timezone handling for MST. | |||
| """ | |||
| TIMEZONE = pytz.timezone('US/Mountain') | |||
There was a problem hiding this comment.
Little did I know that MST is the way to go and 'US/Mountain' is deprecated
There was a problem hiding this comment.
US/Mountain will also apply daylight savings time so you can either miss an hour or double up.
|
|
||
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| base_config = copy.deepcopy(cls.base_config) | ||
| base_config.cfg['time']['time_zone'] = str(cls.TIMEZONE) | ||
| base_config.cfg['time']['time_zone'] = 'MST' |
There was a problem hiding this comment.
Did this call need to b changed?
Or did you want to create a more 'real world' input scenario with it?
There was a problem hiding this comment.
It's a more real world application as we don't typically pass a pytz object. This will also test that the inicheck parser is working. Then TIMEZONE becomes what is checked against
| value: A single string unchanged | ||
| """ | ||
|
|
||
| return value |
There was a problem hiding this comment.
Think this would be worth opening a ticket for and move into 'inicheck'
There was a problem hiding this comment.
Agreed.
There was a problem hiding this comment.
There was a problem hiding this comment.
You got a lower number so you won!
inicheckparses thetime_zonevalue to lowercase, which is fine for UTC but not any other time zones. Added a custom parser that will perform no checking and return the raw string provided.pytzwill error if the timezone cannot be found.