Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue65 #66

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue65 #66

wants to merge 4 commits into from

Conversation

micah-prime
Copy link
Contributor

  • Constrain regex dependency from dateparser to avoid date parsing issues AND work on M2 chips
  • Latest date parser to work on M2 chips
  • Test on Python 3.10 and 3.11

@micah-prime
Copy link
Contributor Author

micah-prime commented Oct 9, 2023

I had to take 3.6 out of the test versions as github no longer will test with it. This is no great loss as it has been out of support for well over a year. An admin will have to override that as a requirements to merge this PR.

On the upside, I added 3.10 and 3.11! 💥

Here is the list of supported versions on github https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@micah-prime
Copy link
Contributor Author

@jomey @Hedrick-ARS I can't see who is part of the ARS org, but hoping one of you could take a look when you have a chance!
Cheers 🍺

Copy link
Collaborator

@jomey jomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @micah-prime, for getting this up to date.

Looks good from my end 👍.

Will leave it up to @Hedrick-ARS as the official ARS authority to approve this by merging without the (now outdated) Python 3.6 pipeline to pass.

@micah-prime
Copy link
Contributor Author

Thanks, @micah-prime, for getting this up to date.

Looks good from my end 👍.

Will leave it up to @Hedrick-ARS as the official ARS authority to approve this by merging without the (now outdated) Python 3.6 pipeline to pass.

Thanks for taking a look @jomey !

@Hedrick-ARS
Copy link

Thanks @micah-prime! Really appreciate you taking the time to do this.

If both you and @jomey think this is what we should do, then I'm all on board.

Questions: How will these changes get propagated through the repos? Is there more that I need to do in order to bring our repos up to reasonable python versions?

@jomey
Copy link
Collaborator

jomey commented Oct 10, 2023

Questions: How will these changes get propagated through the repos? Is there more that I need to do in order to bring our repos up to reasonable python versions?

The two other model components that I found that have inicheck as a Python dependency are SMRF and basin setup. Both have the version for inicheck pinned to less than 0.10. Propagating this change to these two would require cutting a new (higher) version.

Getting all model components to a newer Python version is a different level (and beast). The last Python version I found that the model is running with through all components is 3.7.

@micah-prime
Copy link
Contributor Author

Thanks @micah-prime! Really appreciate you taking the time to do this.

If both you and @jomey think this is what we should do, then I'm all on board.

Questions: How will these changes get propagated through the repos? Is there more that I need to do in order to bring our repos up to reasonable python versions?

You're welcome!

Jumping off of what Joe said, AWSM also depends on it with the assumption that it is brought it from SMRF.

We just went through that process internally (up to Python 3.10 🎉 ). Happy to get a beer and talk about what that took.

In terms of next steps to get this inicheck change published to pypi, after merging you'll need to bump the version and then create a release through github. Let me know if I can lend a hand with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants