Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BXC-4486 add with-works and with-files to perms set cmd #87

Merged
merged 6 commits into from
Mar 15, 2024
Merged

BXC-4486 add with-works and with-files to perms set cmd #87

merged 6 commits into from
Mar 15, 2024

Conversation

krwong
Copy link
Contributor

@krwong krwong commented Mar 11, 2024

https://unclibrary.atlassian.net/browse/BXC-4486

  • PermissionsService: modify updateCsvRecords to accept --with-works and --with-files options
  • add and modify tests

bbpennel
bbpennel requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@bbpennel bbpennel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one potential issue

src/main/java/edu/unc/lib/boxc/migration/cdm/services/PermissionsService.java Show resolved Hide resolved
@bbpennel bbpennel merged commit 994261c into main Mar 15, 2024
2 checks passed
@bbpennel bbpennel deleted the BXC-4486-perms-set-works-files branch March 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbpennel bbpennel bbpennel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krwong @bbpennel