BXC-4415 add object_type column to permissions csv #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
requested changes
Mar 6, 2024
src/main/java/edu/unc/lib/boxc/migration/cdm/model/PermissionsInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/PermissionsService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/PermissionsService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/PermissionsService.java
Outdated
Show resolved
Hide resolved
…st, change isWork to getObjectType and have it return object type, work query constant, remove distinct from queries
bbpennel
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-4415
PermissionsInfo: add object_type column to csv headersPermissionsService: add object_type column to permissions csv, modifyqueryForMappedIdsto return a map of mapped ids and object types, addisWorkhelper methodPermissionsValidator: change csvRecord size from 3 to 4