Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BXC-4130 - Add aggregate mappings #65

Merged
merged 7 commits into from
Aug 23, 2023
Merged

BXC-4130 - Add aggregate mappings #65

merged 7 commits into from
Aug 23, 2023

Conversation

bbpennel
Copy link
Member

@bbpennel bbpennel commented Aug 8, 2023

https://jira.lib.unc.edu/browse/BXC-4130

  • Feature for adding aggregate files to the top and bottom of works
  • Integrate with sip generation
  • Add tests

… stored. Switch delimitor when saving multiple paths to a pipe instead of a comma, since comma is much more likely to occur in filenames and it is being saved in a comma delimited file.
…h grouped works and aggregates. Fixes for when there are no aggregate mappings
@bbpennel bbpennel changed the title BXC-4130 - Add aggregate mappings WIP: BXC-4130 - Add aggregate mappings Aug 17, 2023
@bbpennel bbpennel changed the title WIP: BXC-4130 - Add aggregate mappings BXC-4130 - Add aggregate mappings Aug 21, 2023
Copy link
Contributor

@sharonluong sharonluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sharonluong sharonluong merged commit 18a4314 into main Aug 23, 2023
2 checks passed
@bbpennel bbpennel deleted the bxc-4130-aggregate branch August 23, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants